Skip to content
Permalink
Branch: 3.7
Commits on Jan 30, 2020
  1. [3.7] bpo-39493: Fix definition of IO.closed in typing.py (GH-18273)

    3 people committed Jan 30, 2020
    * bpo-39493: Fix definition of IO.closed in typing.py (GH-18265)
    (cherry picked from commit 2e6569b)
    
    Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
    
    * Use @absractproperty
    
    Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
    Co-authored-by: Guido van Rossum <guido@python.org>
Commits on Jan 29, 2020
  1. bpo-39485: fix corner-case in method-detection of mock (GH-18256)

    miss-islington and cfbolz committed Jan 29, 2020
    Replace check for whether something is a method in the mock module. The
    previous version fails on PyPy, because there no method wrappers exist
    (everything looks like a regular Python-defined function). Thus the
    isinstance(getattr(result, '__get__', None), MethodWrapperTypes) check
    returns True for any descriptor, not just methods.
    
    This condition could also return erroneously True in CPython for
    C-defined descriptors.
    
    Instead to decide whether something is a method, just check directly
    whether it's a function defined on the class. This passes all tests on
    CPython and fixes the bug on PyPy.
    (cherry picked from commit a327677)
    
    Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
    
    Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
  2. Doc: Fix external links to functional programming tutorial. (GH-18249)

    miss-islington and JulienPalard committed Jan 29, 2020
    (cherry picked from commit 35eac45)
    
    Co-authored-by: Julien Palard <julien@palard.fr>
Commits on Jan 28, 2020
  1. bpo-38092: Reduce overhead when using multiprocessing in a Windows vi…

    ameily authored and zooba committed Jan 28, 2020
    …rtual environment (GH-16098)
  2. bpo-39287: Doc: Add UTF-8 mode section in using/windows. (GH-17935)

    miss-islington and methane committed Jan 28, 2020
    Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
    (cherry picked from commit 148610d)
    
    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Commits on Jan 27, 2020
  1. bpo-39392: Turtle overlap fill depends on OS (GH-18223)

    miss-islington and terryjreedy committed Jan 27, 2020
    Whether or not overlap regions for self-intersecting polygons
    or multiple shapes are filled depends on the operating system graphics,
    typeof overlap, and number of overlaps.
    (cherry picked from commit 2824c45)
    
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
  2. bpo-30780: Add IDLE configdialog tests (GH-3592)

    miss-islington and csabella committed Jan 27, 2020
    Expose dialog buttons to test code and complete their test coverage.
    Complete test coverage for highlights and keys tabs.
    
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    (cherry picked from commit dd023ad)
    
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
  3. Ignore NEWS snippets in code coverage stats (GH-18194)

    miss-islington and ncoghlan committed Jan 27, 2020
    (cherry picked from commit 7023288)
    
    Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
Commits on Jan 25, 2020
  1. bpo-39234: Doc: `enum.auto()` incrementation value not specified. (GH…

    2 people authored and ned-deily committed Jan 25, 2020
    …-17872) (GH-17876)
    
    (cherry picked from commit 2e9012a)
    
    Co-authored-by: YoSTEALTH <35307184+YoSTEALTH@users.noreply.github.com>
  2. bpo-36654: Add examples for using tokenize module programmatically (G…

    2 people authored and berkerpeksag committed Jan 25, 2020
    …H-12947)
    
    (cherry picked from commit 4b09dc7)
    
    Co-authored-by: Windson yang <wiwindson@outlook.com>
  3. bpo-15243: Document __prepare__ as classmethod (GH-17124)

    2 people authored and berkerpeksag committed Jan 25, 2020
    (cherry picked from commit 7de6174)
    
    Co-authored-by: alclarks <57201106+alclarks@users.noreply.github.com>
  4. bpo-38473: Handle autospecced functions and methods used with attach_…

    miss-islington and tirkarthi committed Jan 25, 2020
    …mock (GH-16784) (#18166)
    
    If an autospecced object is attached using attach_mock the
    child would be a function with mock object as attribute from
    which signature has to be derived.
    
    (cherry picked from commit 66b00a9)
    
    Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
  5. bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)

    miss-islington and csabella committed Jan 25, 2020
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    (cherry picked from commit d0d9fa8)
    
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Commits on Jan 24, 2020
  1. bpo-39430: Fix race condition in lazy imports in tarfile. (GH-18161)

    miss-islington and serhiy-storchaka committed Jan 24, 2020
    Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
    (cherry picked from commit 9017e0b)
    
    Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Commits on Jan 23, 2020
  1. [3.7] bpo-35182: fix communicate() crash after child closes its pipes (

    alpire authored and miss-islington committed Jan 23, 2020
    …GH-18117) (GH-18151)
    
    When communicate() is called in a loop, it crashes when the child process
    has already closed any piped standard stream, but still continues to be running
    
    Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>.
    (cherry picked from commit d3ae95e)
    
    Co-authored-by: Alex Rebert <alex@forallsecure.com>
    
    
    
    
    
    https://bugs.python.org/issue35182
    
    
    
    Automerge-Triggered-By: @gpshead
  2. bpo-39431: Also mention nonlocal in assignment quirk (GH-17375)

    miss-islington and shanavas786 committed Jan 23, 2020
    (cherry picked from commit 7142df5)
    
    Co-authored-by: Shanavas M <shanavas.m2@gmail.com>
  3. bpo-39421: Fix posible crash in heapq with custom comparison operators (

    miss-islington and pablogsal committed Jan 23, 2020
    GH-18118)
    
    * bpo-39421: Fix posible crash in heapq with custom comparison operators
    
    * fixup! bpo-39421: Fix posible crash in heapq with custom comparison operators
    
    * fixup! fixup! bpo-39421: Fix posible crash in heapq with custom comparison operators
    (cherry picked from commit 79f89e6)
    
    Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
  4. bpo-32989: IDLE - remove unneeded parameter (GH-18138)

    miss-islington and terryjreedy committed Jan 23, 2020
    IDLE does not pass a non-default _synchre in any of its calls to
    pyparse.find_good_parse_start.
    (cherry picked from commit f9e07e1)
    
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
  5. bpo-39050: The Help button in IDLE's config menu works again (GH-17611)

    miss-islington and ZackerySpytz committed Jan 23, 2020
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    (cherry picked from commit 2e43b64)
    
    Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Commits on Jan 22, 2020
  1. bpo-39425: Fix list.count performance regression (GH-18119) (GH-18121)

    2 people authored and pablogsal committed Jan 22, 2020
    https://bugs.python.org/issue39425
    
    Automerge-Triggered-By: @pablogsal
    (cherry picked from commit 14d80d0)
    
    Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
    
    Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
  2. bpo-39413: os.unsetenv() is not available on Windows (GH-18108)

    miss-islington and vstinner committed Jan 22, 2020
    Update os.unsetenv() documentation: it is not available on Windows.
    (cherry picked from commit f84f65b)
    
    Co-authored-by: Victor Stinner <vstinner@python.org>
Commits on Jan 21, 2020
  1. PyLong_AsLongLong() docs should say 'long long' (GH-18082) (#18109)

    2 people authored and mdickinson committed Jan 21, 2020
    (cherry picked from commit 47be7d0)
    
    Co-authored-by: Keith Erskine <toastie604@gmail.com>
    
    Co-authored-by: Keith Erskine <toastie604@gmail.com>
  2. bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968)

    miss-islington and csabella committed Jan 21, 2020
    Fix comments and add tests for editor newline_and_indent_event method.
    Remove unused None default for function parameter of pyparse find_good_parse_start method
    and code triggered by that default.
    
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    (cherry picked from commit ec64640)
    
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
  3. improve the documentation of the LOAD_METHOD and CALL_METHOD (GH-18079)

    miss-islington and cfbolz committed Jan 21, 2020
    (cherry picked from commit 8698b34)
    
    Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
Commits on Jan 20, 2020
  1. bpo-39383: Mention Darwin as a potential value for platform.system() (G…

    miss-islington and bittner committed Jan 20, 2020
    …H-18054)
    
    (cherry picked from commit 8d57a41)
    
    Co-authored-by: Peter Bittner <django@bittner.it>
  2. bpo-39386: Prevent double awaiting of async iterator (GH-18081)

    miss-islington and asvetlov committed Jan 20, 2020
    (cherry picked from commit a96e06d)
    
    Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
  3. Fix asyncio.get_event_loop() documentation (GH-18051)

    miss-islington and asvetlov committed Jan 20, 2020
    Mention that the function implicitly creates new event loop only if called from the main thread.
    (cherry picked from commit 2c49bec)
    
    Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Commits on Jan 19, 2020
  1. bpo-38400 Don't check for NULL linked list pointers in _PyObject_IsFr…

    miss-islington and pablogsal committed Jan 19, 2020
    …eed (GH-16630)
    
    Some objects like Py_None are not initialized with conventional means
    that prepare the circular linked list pointers, leaving them unlinked
    from the rest of the objects. For those objects, NULL pointers does
    not mean that they are freed, so we need to skip the check in those
    cases.
    (cherry picked from commit 36e33c3)
    
    Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
  2. bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (GH-18060)

    miss-islington and ZackerySpytz committed Jan 19, 2020
    Update Misc/valgrind-python.supp to suppress the false alarm.
    (cherry picked from commit d8ef644)
    
    Co-authored-by: Zackery Spytz <zspytz@gmail.com>
  3. Fix typo from base to based (GH-18055)

    miss-islington and micha2718l committed Jan 19, 2020
    (cherry picked from commit 558f078)
    
    Co-authored-by: Michael Haas <micha2718l@gmail.com>
Commits on Jan 17, 2020
  1. Fix Lock.locked() to remove extra bold highlighting (GH-18042) (#18044)

    2 people authored and warsaw committed Jan 17, 2020
    (cherry picked from commit ef8844f)
    
    Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
    
    Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
Commits on Jan 16, 2020
  1. bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018)

    miss-islington and oz123 committed Jan 16, 2020
    The previous double colon was wrongly place directly after Therefore.
    Which produced a block without syntax highlighting. This fixes it
    by separating the double colon from the text. As a result, sphinx now
    properly highlights the python code.
    
    https://bugs.python.org/issue39348
    (cherry picked from commit fad8b56)
    
    Co-authored-by: Oz N Tiram <oz.tiram@noris.de>
Commits on Jan 15, 2020
  1. [3.7] Fix typo in multiprocessing.pool.AsyncResult.successful doc. (G…

    miss-islington committed Jan 15, 2020
    …H-17932) (GH-18016)
    
    Since 3.7 `successful` raises a `ValueError` as explained in the next text block from the documentation:
    
    _Changed in version 3.7: If the result is not ready, ValueError is raised instead of AssertionError._
    
    No issue associated with this PR.
    Should be backported in 3.7 and 3.8.
    (cherry picked from commit dc0284e)
    
    
    Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
    
    Automerge-Triggered-By: @pitrou
Commits on Jan 14, 2020
  1. Fix documentation in code.py (GH-17988)

    miss-islington and kylepollina committed Jan 14, 2020
    (cherry picked from commit b4cdb3f)
    
    Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
Older
You can’t perform that action at this time.