Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-2986: Allow disabling difflib's automatic junk heuristic #17082

Closed
wants to merge 1 commit into from
Closed

bpo-2986: Allow disabling difflib's automatic junk heuristic #17082

wants to merge 1 commit into from

Conversation

liamFerris
Copy link

@liamFerris liamFerris commented Nov 7, 2019 •
edited by bedevere-bot 

[bpo-2986](https://bugs.python.org/issue2986): Allow disabling difflib's automatic junk heuristic

Added parameter for autojunk to the Differ class and the ndiff method to allow disabling the automatic junk heuristic.

I am using difflib extensively as part of a current project. We are working across a large amount of text, and for our purposes quality is preferred over speed. We have examples of where the diff algorithm fails (fails meaning treats the majority of our input as one large deletion / addition) with autojunking enabled and does not without, meaning we are required to set this parameter to false for our purposes.

This parameter is not accessible to us from the API provided by difflib currently. To resolve this we have copied this out and modified it in a similar way to this PR.

The issue we are facing plus the suggestion to allow this parameter to be configured it mentioned by others in bpo-2986.

Thanks, Liam

https://bugs.python.org/issue2986

@liamFerris
autojunk parameter added to ndiff method and to Differ class so that …
1c5718d 
…autojunking can be turned on or off when calling ndiff. Using default value similar to SequenceMatcher
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Nov 7, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@liamFerris

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link

@csabella csabella commented Jan 25, 2020

@liamFerris, the bot isn't finding a signed CLA for you. We are unable to accept contributions that don't have a signed CLA, so please take a look at the directions above to submit that. Thank you!

@csabella
Copy link

@csabella csabella commented Feb 3, 2020

I'm going to close this PR as the CLA hasn't been signed. It can be reopened once that is taken care of. Thank you.

@csabella csabella closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review CLA not signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liamFerris @the-knights-who-say-ni @csabella @bedevere-bot