Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39460: Disable test_zipfile.test_add_file_after_2107() #18247

Merged
merged 2 commits into from Jan 29, 2020
Merged

bpo-39460: Disable test_zipfile.test_add_file_after_2107() #18247

merged 2 commits into from Jan 29, 2020
+12 −0

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 29, 2020 •
edited by bedevere-bot

Disable the test because it fails on Fedora Rawhide with XFS
filesystem.

https://bugs.python.org/issue39460
@vstinner
bpo-39460: Disable test_zipfile.test_add_file_after_2107()
Loading status checks…
d081045 
Disable the test because it fails on Fedora Rawhide with XFS
filesystem.
@vstinner vstinner added the skip news label Jan 29, 2020
@hroncok

This comment has been minimized.

Sign in to view
Copy link
Contributor

hroncok commented Jan 29, 2020

Can we do a detection on only skip if the timestamp is weird?
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 29, 2020

Can we do a detection on only skip if the timestamp is weird?

Maybe. But it seems simpler to me to skip the test until the kernel bug is fixed.
@vstinner
Only skip the test if the Linux VFS/XFS bug is detected
Loading status checks…
d2a3f06
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #18247 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18247     +/-   ##
=========================================
  Coverage   82.12%   82.12%             
=========================================
  Files        1955     1954      -1     
  Lines      588721   583389   -5332     
  Branches    44382    44382             
=========================================
- Hits       483463   479090   -4373     
+ Misses      95628    94673    -955     
+ Partials     9630     9626      -4
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e8000...d2a3f06. Read the comment docs.
@hroncok
hroncok reviewed Jan 29, 2020
View changes
Lib/test/test_zipfile.py
@@ -616,6 +616,18 @@ def test_add_file_after_2107(self):
except OverflowError:
self.skipTest('Host fs cannot set timestamp to required value.')

mtime_ns = os.stat(TESTFN).st_mtime_ns
if mtime_ns != (4386268800 * 10**9):

This comment has been minimized.

Sign in to view
Copy link
@hroncok

hroncok Jan 29, 2020

Contributor

Just curious. Would you consider this better or worse than the 2 lines one?

Suggested change
if mtime_ns != (4386268800 * 10**9):
if (mtime_ns := os.stat(TESTFN).st_mtime_ns) != (4386268800 * 10**9):

This comment has been minimized.

Sign in to view
Copy link
@vstinner

vstinner Jan 29, 2020

Author Member

My opinion: I prefer to not use "mtime := ..." here. I like to have an explicitement assignement statement on a separated line ;-)
@vstinner vstinner merged commit 3cb49b6 into python:master Jan 29, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200129.18 succeeded
Details
bedevere/issue-number Issue number 39460 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner vstinner deleted the vstinner:test_zipfile branch Jan 29, 2020
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 29, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 29, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 29, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 29, 2020

GH-18253 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 29, 2020
@vstinner @miss-islington
bpo-39460: Fix test_zipfile.test_add_file_after_2107() (pythonGH-18247)
b1136de 
XFS filesystem is limited to 32-bit timestamp, but the utimensat()
syscall doesn't fail. Moreover, there is a VFS bug which returns
a cached timestamp which is different than the value on disk.

https://bugzilla.redhat.com/show_bug.cgi?id=1795576
https://bugs.python.org/issue39460GH-msg360952
(cherry picked from commit 3cb49b6)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Jan 29, 2020
@miss-islington @vstinner
bpo-39460: Fix test_zipfile.test_add_file_after_2107() (GH-18247)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b675f0 
XFS filesystem is limited to 32-bit timestamp, but the utimensat()
syscall doesn't fail. Moreover, there is a VFS bug which returns
a cached timestamp which is different than the value on disk.

https://bugzilla.redhat.com/show_bug.cgi?id=1795576
https://bugs.python.org/issue39460GH-msg360952
(cherry picked from commit 3cb49b6)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok

Assignees
No one assigned
Labels
CLA signed skip news type-tests
Projects
None yet
Milestone
No milestone
5 participants
@vstinner @hroncok @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.