Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39033: Fix NameError in zipimport during hash validation #17588
+286
−269
Conversation
tirkarthi
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as
code owners
|
Nice catch from the issuer :) Looks good to me! |
|
Nice catch! At some point we should probably just search the entire code base for references to "boostrap"... |
This comment has been minimized.
This comment has been minimized.
|
Thanks Nick. I think this can be backported to 3.8 too. This changes the importlib header file and I guess it's allowed to change between bug fix versions. |
This comment has been minimized.
This comment has been minimized.
|
@tirkarthi yes, the header files can change in bugfix releases. But it does mean backporting will have to be done in manual PRs to get the right bytecode. |
This comment has been minimized.
This comment has been minimized.
|
Ah yes, thanks Brett I will make a manual backport with the generated header file. |
tirkarthi
added a commit
to tirkarthi/cpython
that referenced
this pull request
Dec 17, 2019
tirkarthi
added a commit
to tirkarthi/cpython
that referenced
this pull request
Dec 23, 2019
miss-islington
added a commit
that referenced
this pull request
Jan 14, 2020
…H-17588) (GH-17642) Fix `NameError` in `zipimport` during hash validation and add a regression test. (cherry picked from commit 79f02fe) https://bugs.python.org/issue39033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tirkarthi commentedDec 13, 2019
•
edited by bedevere-bot
Fix
NameErrorinzipimportduring hash validation and add a regression test.https://bugs.python.org/issue39033