Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34770: Fix a possible null pointer dereference in pyshellext.cpp #9497

Conversation

Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Sep 22, 2018

The GlobalLock() call in UpdateDropDescription() was not checked for
failure.

https://bugs.python.org/issue34770

The GlobalLock() call in UpdateDropDescription() was not checked for
failure.
@zhangyangyu zhangyangyu added needs backport to 3.6 OS-windows needs backport to 3.7 🤖 automerge labels Sep 25, 2018
@miss-islington miss-islington merged commit f6c8007 into python:master Sep 25, 2018
9 checks passed
@miss-islington
Copy link

@miss-islington miss-islington commented Sep 25, 2018

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 25, 2018
…ythonGH-9497)

The GlobalLock() call in UpdateDropDescription() was not checked for
failure.

https://bugs.python.org/issue34770
(cherry picked from commit f6c8007)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 25, 2018

GH-9555 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 25, 2018
…ythonGH-9497)

The GlobalLock() call in UpdateDropDescription() was not checked for
failure.

https://bugs.python.org/issue34770
(cherry picked from commit f6c8007)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 25, 2018

GH-9556 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this issue Sep 25, 2018
…H-9497)

The GlobalLock() call in UpdateDropDescription() was not checked for
failure.

https://bugs.python.org/issue34770
(cherry picked from commit f6c8007)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this issue Sep 25, 2018
…H-9497)

The GlobalLock() call in UpdateDropDescription() was not checked for
failure.

https://bugs.python.org/issue34770
(cherry picked from commit f6c8007)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@ZackerySpytz ZackerySpytz deleted the bpo-34770-pyshellext.cpp-GlobalLock-NULL branch Sep 26, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this issue Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed OS-windows 🤖 automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants