bpo-38771 #17108
bpo-38771 #17108
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
| @@ -162,7 +162,7 @@ environment variables which in turn take precedence over default values:: | |||
| parser.add_argument('-u', '--user') | |||
| parser.add_argument('-c', '--color') | |||
| namespace = parser.parse_args() | |||
| command_line_args = {k:v for k, v in vars(namespace).items() if v} | |||
| command_line_args = {k: v for k, v in vars(namespace).items() if v is not None} | |||
There was a problem hiding this comment.
I think reads better without the space before v.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks @jonathan-scholbach for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-17109 is a backport of this pull request to the 3.8 branch. |
|
GH-17110 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 98480ce) Co-authored-by: Jonathan Scholbach <j.scholbach@posteo.de>
https://bugs.python.org/issue38771