Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore NEWS snippets in code coverage stats #18194

Merged
merged 1 commit into from Jan 27, 2020
Merged

Ignore NEWS snippets in code coverage stats #18194

merged 1 commit into from Jan 27, 2020

Conversation

@ncoghlan
Copy link
Contributor

ncoghlan commented Jan 26, 2020

In trying to work out what was wrong with the code coverage stats on #18066,
I realised we weren't ignoring the Misc/NEWS.d subdirectory correctly.
@ncoghlan
Ignore NEWS snippets in code coverage stats
Loading status checks…
90139ef
@ncoghlan ncoghlan mentioned this pull request Jan 26, 2020
Closed
@shihai1991
shihai1991 approved these changes Jan 26, 2020
View changes
Copy link
Contributor

shihai1991 left a comment

LGTM, thanks.
@methane
methane approved these changes Jan 27, 2020
View changes
@ncoghlan ncoghlan merged commit 7023288 into python:master Jan 27, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200126.10 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ncoghlan ncoghlan deleted the ncoghlan:ignore-misc-subdirs-in-codecov branch Jan 27, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 27, 2020

If coverage tests are run on other branches, you may want to backport your change to 3.7 and 3.8.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

Sorry @ncoghlan, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7023288dc500008609e7a4d12ae710c2093c3fc6 3.8
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@ncoghlan @miss-islington
Ignore NEWS snippets in code coverage stats (pythonGH-18194)
4972a94 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 27, 2020

GH-18200 is a backport of this pull request to the 3.7 branch.
@ncoghlan

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ncoghlan commented Jan 27, 2020

Good point!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@ncoghlan @miss-islington
Ignore NEWS snippets in code coverage stats (pythonGH-18194)
eed50cc 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 27, 2020

GH-18201 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @ncoghlan
Ignore NEWS snippets in code coverage stats (GH-18194)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
414ab5d 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @ncoghlan
Ignore NEWS snippets in code coverage stats (GH-18194)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
57e7e57 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

@shihai1991 shihai1991

Assignees

@ncoghlan ncoghlan

Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
7 participants
@ncoghlan @vstinner @miss-islington @bedevere-bot @methane @shihai1991 @the-knights-who-say-ni
You can’t perform that action at this time.