Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRedundant expression #18193
Redundant expression #18193
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Jan 26, 2020
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
LGTM. I think this don't change the functionality of the functions. But I would like to hear a core dev :) |
This comment has been minimized.
This comment has been minimized.
|
@gaurav1086 please, sign CLA. |
This comment has been minimized.
This comment has been minimized.
|
Hi @eamanu, thanks for the review. I have signed the CLA and also received the copy of it. Not sure why its showing as 'not signed'. I signed it today itself. I think it takes 1 business day to be reviewed. |
This comment has been minimized.
This comment has been minimized.
|
@gaurav1086 Oh ok. we just need wait :) |
This comment has been minimized.
This comment has been minimized.
|
The files are taken from the blake2 reference implementation. I don't want to deviate from upstream. Any good compiler will know how to optimize this line anyway. |
gaurav1086 commentedJan 26, 2020
No description provided.