Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33388: Add variables to distutils/dist.py support PEP 566 metadata #6642

Closed
wants to merge 3 commits into from

Conversation

rbricheno
Copy link

@rbricheno rbricheno commented Apr 29, 2018

These variables are used in setuptools to support PEP 566 'Description-Content-Type' and 'Provides-Extra':

https://www.python.org/dev/peps/pep-0566/
http://setuptools.readthedocs.io/en/latest/setuptools.html#metadata

Currently dist.py in CPython will warn if they are set, e.g.:

dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'

The warnings seem spurious, but looked a bit scary to me as a new user. By declaring these variables, the warnings are no longer displayed. long_description_content_type, at least, is being used in the wild since:

pypa/sampleproject@5be0970

https://bugs.python.org/issue33388

These variables are used in setuptools to support PEP 566 'Description-Content-Type' and 'Provides-Extra':

https://www.python.org/dev/peps/pep-0566/
http://setuptools.readthedocs.io/en/latest/setuptools.html#metadata

Currently dist.py in CPython will warn if they are set, e.g.:

`dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'`

The warnings seem spurious, but looked a bit scary to me as a new user. By declaring these variables, the warnings are no longer displayed. long_description_content_type, at least, is being used in the wild since:

pypa/sampleproject@5be0970
Copy link
Member

@merwok merwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion on bpo

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella csabella added the stale Stale PR or inactive for long period of time. label Jan 25, 2020
@csabella
Copy link
Contributor

@rbricheno, please address the questions on the bug tracker. Thank you!

@csabella
Copy link
Contributor

I'm going to close this PR as inactive. The bug tracker discussion might need to be updated with the current status of packaging and whether this issue is still relevant.

@csabella csabella closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants