Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39502: Fix 64-bit Python PyTime_localtime() on AIX #18285

Open
wants to merge 3 commits into
base: master
from
Open

bpo-39502: Fix 64-bit Python PyTime_localtime() on AIX #18285

wants to merge 3 commits into from
+3 −1

Conversation

@aixtools
Copy link
Contributor

aixtools commented Jan 30, 2020 •
edited by bedevere-bot

so that only 32-bit is range tested for overflow

https://bugs.python.org/issue39502
@aixtools
Fix PyTime_localtime() on AIX so that only 32-bit is range tested for…
Loading status checks…
c54fe56 
… overflow
@aixtools aixtools requested review from abalkin and pganssle as code owners Jan 30, 2020
@vstinner
vstinner reviewed Jan 30, 2020
View changes
Misc/NEWS.d/next/Core and Builtins/2020-01-30-14-36-31.bpo-39502.IJu0rl.rst Outdated
@@ -0,0 +1,2 @@
Fix PyTime_localtime() on AIX so that only 32-bit is range tested for overflow.

This comment has been minimized.

Sign in to view
Copy link
@vstinner

vstinner Jan 30, 2020

Member

I prefer to mention time.localtime() which is seen by users, than mention a private C function. 32-bit overflow is also obscure. I propose:

Fix :func:`time.localtime` on 64-bit AIX  to support years before 1902 and after 2038.
Patch by M Felt.
Python/pytime.c Outdated Show resolved Hide resolved
aixtools added 2 commits Jan 30, 2020
@aixtools
modify macro format and variable tested
Loading status checks…
a19eaae
@aixtools
Modify blurb to specify user function name, rather than internal func…
Loading status checks…
0ded2ba 
…tion name
@pganssle

This comment has been minimized.

Sign in to view
Copy link
Member

pganssle commented Jan 30, 2020 •
edited

@aixtools Can you add a test for this? Does it fix a test that is currently broken on the AIX buildbot or skipped in the test suite?

Edit: Looks like #18282 skipped this particular test, I guess you can remove the skip directive that was added there.
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 30, 2020

Edit: Looks like #18282 skipped this particular test, I guess you can remove the skip directive that was added there.

This PR is only for 64-bit AIX. The skip is still useful for 32-bit AIX which is still limited to year 2038: see https://bugs.python.org/issue39502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@abalkin abalkin

@pganssle pganssle

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
5 participants
@aixtools @pganssle @vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.