Skip to content

Remove some unused defines in multiprocessing.h #15661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2019

Conversation

sir-sigurd
Copy link
Contributor

It looks like they are unused since 87cf220.

It looks like they are unused since
87cf220.
Copy link
Member

@ammaraskar ammaraskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As pointed out, looks like these typedefs were used in the now removed connection.h 87cf220#diff-2da7b80f91407749d5d59087c2406e09

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F_DWORD and T_DWORD are not used too.

@serhiy-storchaka
Copy link
Member

Also _PyMp_SetError is always called as _PyMp_SetError(NULL, MP_STANDARD_ERROR). It can be simplified. But I suggest to open a separate issue for this.

@serhiy-storchaka serhiy-storchaka merged commit 32f8253 into python:master Sep 7, 2019
@sir-sigurd sir-sigurd deleted the multiprocessing-define branch September 7, 2019 07:45
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants