Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-21600: Fix `mock.patch.dict` to be stopped with `mock.patch.stopall` #17606
+69
−2
Conversation
|
Either we can have |
Misc/NEWS.d/next/Library/2019-12-14-14-38-40.bpo-21600.kC4Cgh.rst
Outdated
Show resolved
Hide resolved
As the function was not registering in the active patches, the mocks started by `mock.patch.dict` were not being stopped when `mock.patch.stopall` was being called.
|
LGTM. Thanks Mario :) |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 24, 2020
|
@cjw296: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mariocj89 commentedDec 14, 2019
•
edited by bedevere-bot
As the function was not registering in the active patches, the mocks
started by
mock.patch.dictwere not being stopped whenmock.patch.stopallwas being called.https://bugs.python.org/issue21600