Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-39320: Handle unpacking of **values in compiler #18141
Merged
+3,670
−3,662
Conversation
markshannon
force-pushed the
markshannon:handle-dict-unpacking-in-compiler
branch
from
b6ad237
to
95e421c
| @@ -0,0 +1,12 @@ | |||
|
|
|||
| Replace two complex bytecodes for building dicts with two simpler ones. | |||
|
|
|||
This comment has been minimized.
This comment has been minimized.
pablogsal
Jan 23, 2020
Member
Different paragraphs render badly when joining the NEWS entries, sadly
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 23, 2020
|
If you want to schedule another build, you need to add the " |
This comment has been minimized.
This comment has been minimized.
|
The failures in |
This comment has been minimized.
This comment has been minimized.
|
OK, merging. |
markshannon
merged commit 8a4cd70
into
python:master
41 of 44 checks passed
41 of 44 checks passed
bedevere/news
News entry found in Misc/NEWS.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markshannon commentedJan 23, 2020
•
edited by bedevere-bot
This is the second part of the implementation of bpo-39320.
Part 1 was #17984
This PR replaces BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL
with DICT_MERGE and DICT_UPDATE.
DICT_UPDATE ncallsitem_n.update(tos)whereitem_nis thenth item on the stack andtosis popped from the stack.DICT_MERGE nis the same, but raises an exception if there are duplicate keys.https://bugs.python.org/issue39320