Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38881: choices() raises ValueError when all weights are zero #17362

Merged
merged 3 commits into from Nov 23, 2019
Merged

bpo-38881: choices() raises ValueError when all weights are zero #17362

merged 3 commits into from Nov 23, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Nov 23, 2019 •
edited by bedevere-bot

@rhettinger rhettinger requested a review from tim-one Nov 23, 2019
tim-one
tim-one reviewed Nov 23, 2019
View changes
Copy link
Member

@tim-one tim-one left a comment

Suggested related rephrasings.

Doc/library/random.rst Outdated Show resolved Hide resolved
Doc/library/random.rst Outdated Show resolved Hide resolved
@rhettinger rhettinger merged commit 041d8b4 into python:master Nov 23, 2019
4 checks passed
@rhettinger rhettinger deleted the zero_random_choices branch Nov 23, 2019
mdickinson
mdickinson approved these changes Nov 23, 2019
View changes
Copy link
Member

@mdickinson mdickinson left a comment

LGTM

@mdickinson
Copy link
Member

mdickinson commented Nov 23, 2019

(Whoops; sorry; I had an unrefreshed view of this PR in my browser - I didn't realise this had already been merged. LGTM nevertheless ...)

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@rhettinger @jacobneiltaylor
bpo-38881: choices() raises ValueError when all weights are zero (pyt…
5b00c6d 
…honGH-17362)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@rhettinger @shihai1991
bpo-38881: choices() raises ValueError when all weights are zero (pyt…
857f180 
…honGH-17362)
Reviewers

@tim-one tim-one

@mdickinson mdickinson

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhettinger @mdickinson @tim-one @the-knights-who-say-ni @bedevere-bot