Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38631: Add _Py_NO_RETURN to functions calling Py_FatalError() #18278
+6
−20
Conversation
This comment has been minimized.
This comment has been minimized.
|
About clang "code will never be executed [-Wunreachable-code]" warning: I compiled Python using clang -O3. There is one warning, but it's unrelated to this change: I tested clang version 9.0.0 (Fedora 9.0.0-1.fc31). |
Add _Py_NO_RETURN to functions calling Py_FatalError(): * _PyObject_AssertFailed() * dummy_dealloc() * faulthandler_fatal_error_thread() * none_dealloc() * notimplemented_dealloc()
This comment has been minimized.
This comment has been minimized.
|
Note: marking _PyObject_AssertFailed() with _Py_NO_RETURN idea comes from a GCC 10 regression bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93384#c17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 30, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue38631