Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33987: IDLE: Use ttk Frame on help.py #11433

Merged
merged 2 commits into from Oct 22, 2020
Merged

bpo-33987: IDLE: Use ttk Frame on help.py #11433

merged 2 commits into from Oct 22, 2020

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Jan 4, 2019 •
edited by bedevere-bot

  • Convert help.py to ttk frame.
  • Use of ttk Style is similar to configdialog.py. Without having to introduce ttk styles and themes too much, this is basically a specific replacement to the old usage of background on Label.
  • I left off the blurb since I used the same ticket number. Since you did all the other screens under one ticket, I didn't know if you wanted to reuse that or create a new ticket for this.

https://bugs.python.org/issue33987

@csabella csabella requested a review from terryjreedy as a code owner Jan 4, 2019
terryjreedy
terryjreedy approved these changes Oct 22, 2020
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

I will add a news item after also converting searchbase, as that will have a visible impact at least on macOS.

Lib/idlelib/help.py
@@ -212,7 +212,9 @@ class HelpFrame(Frame):
def __init__(self, parent, filename):
Frame.__init__(self, parent)
self.text = text = HelpText(self, filename)
self['background'] = text['background']
self.style = Style(parent)
self['style'] = 'helpframe.TFrame'
Copy link
Member

@terryjreedy terryjreedy Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the gray background for the menubutton extended down the entire length of the window. I prefer the current box just around [TOC V].

@terryjreedy terryjreedy merged commit facb522 into python:master Oct 22, 2020
4 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 22, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2020
@csabella @miss-islington
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (pythonGH-…
3363b95 
…11433)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2020

GH-22899 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2020
@csabella @miss-islington
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (pythonGH-…
ae58210 
…11433)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2020

GH-22900 is a backport of this pull request to the 3.8 branch.

terryjreedy pushed a commit that referenced this pull request Oct 22, 2020
@miss-islington @csabella
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (GH-11433) (…
25687bb 
…GH-22899)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
terryjreedy pushed a commit that referenced this pull request Oct 22, 2020
@miss-islington @csabella
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (GH-11433) (…
06c9e01 
…GH-22900)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the frame branch Oct 23, 2020
@csabella
Copy link
Contributor Author

csabella commented Oct 23, 2020

Thanks for reviewing and merging this! :-)

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@csabella @adorilson
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (pythonGH-…
a45225c 
…11433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni