bpo-39087: Add PyUnicode_GetUTF8Buffer().

Update doc
Write tests in C
python · methane · methane · methane · Dec 19, 2019 · methane
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
diff --git a/Doc/c-api/unicode.rst b/Doc/c-api/unicode.rst
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
+        from _testcapi import unicode_getutf8buffer, test_unicode_getutf8buffer
+
+        # Run tests wrtten in C.  Raise an error when test failed.
+        test_unicode_getutf8buffer()
diff --git a/Doc/c-api/unicode.rst b/Doc/c-api/unicode.rst
@@ -1061,6 +1061,28 @@ These are the UTF-8 codec APIs:
   raised by the codec.


+.. c:function: int PyUnicode_GetUTF8Buffer(PyObject *unicode, const char errors, Py_buffer *view)
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+    }
+    Py_ssize_t refcnt = Py_REFCNT(str);
+
+    if (PyUnicode_GetUTF8Buffer(str, NULL,  &buf) < 0) {
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
+    def test_getutf8buffer(self):
+        from _testcapi import unicode_getutf8buffer
+
+        ascii_ = "foo"
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
+        return PyBuffer_FillInfo(view, unicode,
+                PyUnicode_UTF8(unicode),
+                PyUnicode_UTF8_LENGTH(unicode),
+                1, PyBUF_SIMPLE);
-                1, PyBUF_SIMPLE);
+                1 /* readonly */, PyBUF_SIMPLE);
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
+    }
+
+    if (PyUnicode_UTF8(unicode) != NULL) {
+        return PyBuffer_FillInfo(view, unicode,
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+{
+    PyObject *unicode;
+    const char *errors = NULL;
+    if(!PyArg_ParseTuple(args, "U|s", &unicode, &errors)) {
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+                         "without exception set. (%s:%d)",
+                         __FILE__, __LINE__);
+        }
+        Py_DECREF(str);
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+        return NULL;
+    }
+
+    if (buf.obj == str || !PyBytes_CheckExact(buf.obj)) {
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+    // Test 3: There is a UTF-8 cache
+    // Reuse str of the previoss test.
+
+    const char *cache = PyUnicode_AsUTF8(str);
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+                         "without exception set. (%s:%d)",
+                         __FILE__, __LINE__);
+        }
+        Py_DECREF(str);
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
+                     "Py_REFCNT(str) must not be changed. (%s:%d)",
+                     __FILE__, __LINE__);
+        PyBuffer_Release(&buf);
+        Py_DECREF(str);