Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and fix assertions that mocks have not been awaited #18196

Open
wants to merge 2 commits into
base: master
from
Open

Clarify and fix assertions that mocks have not been awaited #18196

wants to merge 2 commits into from
+32 −27

Conversation

@cjw296
Copy link
Contributor

cjw296 commented Jan 27, 2020

  • The gc.collect is needed for other implementations, such as pypy
  • Using context managers over multiple lines will only catch the warning from the first line in the context!
  • remove a skip that's no longer needed
cjw296 added 2 commits Jan 27, 2020
@cjw296
Clarify and fix assertions that mocks have not been awaited.
0872bf3 
- The gc.collect is needed for other implementations, such as pypy
- Using context managers over multiple lines will only catch the warning from the first line in the context!
@cjw296
this no longer fails on pypy
Loading status checks…
e8e021f
@cjw296 cjw296 requested review from tirkarthi and lisroach Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@lisroach lisroach

Assignees
No one assigned
Labels
CLA signed awaiting core review skip issue skip news
Projects
None yet
Milestone
No milestone
3 participants
@cjw296 @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.