Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix outdated comment in _strptime.py #17929
Merged
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
@taleinat Could you help with the "skip news" and "skip issue" tags? |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
@cool-RR, please check whether this needs back-porting to 3.8 and 3.7. |
This comment has been minimized.
This comment has been minimized.
|
@taleinat LOL, that code is 17 years old. I'm not sure I understand all the criteria for backporting, but as far as I understand, backporting this fix would be valid, though not very important. |
|
I am indifferent about backporting this. I suppose it depends on what we normally do for inaccurate code comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cool-RR commentedJan 9, 2020
•
edited by miss-islington
Can I please get the tags for skipping bpo and skipping a news item?
Automerge-Triggered-By: @pganssle