Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39493: Fix definition of IO.closed in typing.py #18265
Merged
+2
−0
Conversation
gvanrossum
merged commit 2e6569b
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 30, 2020
|
@gvanrossum: Please replace |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 30, 2020
|
Thanks @hauntsaninja for the PR, and @gvanrossum for merging it |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 30, 2020
|
Thanks @hauntsaninja for the PR, and @gvanrossum for merging it |
This comment has been minimized.
This comment has been minimized.
|
I'm guessing this deserves some backporting. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 30, 2020
|
GH-18273 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2020
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 30, 2020
|
GH-18274 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2020
miss-islington
added a commit
that referenced
this pull request
Jan 30, 2020
gvanrossum
added a commit
that referenced
this pull request
Jan 30, 2020
* bpo-39493: Fix definition of IO.closed in typing.py (GH-18265) (cherry picked from commit 2e6569b) Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com> * Use @absractproperty Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com> Co-authored-by: Guido van Rossum <guido@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
hauntsaninja commentedJan 30, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39493