Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-38883: Don't honor POSIX `HOME` in `pathlib.Path.home/expanduser` on Windows #17961
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm not sure if I should add a "versionadded" and what it should say, since both functions are documented as working like "expanduser" and this is more like a bug fix than a change. |
|
thanks! |
This comment has been minimized.
This comment has been minimized.
|
I agree, it's a bugfix rather than a change. The NEWS file is sufficient. |
zooba
merged commit c45a2aa
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 28, 2020
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 28, 2020
…on Windows (pythonGH-17961) In bpo-36264 os.path.expanduser was changed to ignore HOME on Windows. Path.expanduser/home still honored HOME despite being documented as behaving the same as os.path.expanduser. This makes them also ignore HOME so that both implementations behave the same way again. (cherry picked from commit c45a2aa) Co-authored-by: Christoph Reiter <reiter.christoph@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 28, 2020
|
GH-18229 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 28, 2020
…on Windows (GH-17961) In bpo-36264 os.path.expanduser was changed to ignore HOME on Windows. Path.expanduser/home still honored HOME despite being documented as behaving the same as os.path.expanduser. This makes them also ignore HOME so that both implementations behave the same way again. (cherry picked from commit c45a2aa) Co-authored-by: Christoph Reiter <reiter.christoph@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lazka commentedJan 12, 2020
•
edited by bedevere-bot
In bpo-36264 os.path.expanduser was changed to ignore HOME on Windows.
Path.expanduser/home still honored HOME despite being documented as behaving the same
as os.path.expanduser. This makes them also ignore HOME so that both implementations
behave the same way again.
https://bugs.python.org/issue38883