Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.8.rst #18173

Merged
merged 1 commit into from Jan 25, 2020
Merged

Update 3.8.rst #18173

merged 1 commit into from Jan 25, 2020

Conversation

@fireattack
Copy link
Contributor

fireattack commented Jan 24, 2020

Fixed the name of the contributor (@selik).
@fireattack
Update 3.8.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
afec522 
Fixed the name of the contributor (@selik).
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 24, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@fireattack

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@selik
selik approved these changes Jan 24, 2020
View changes
Copy link
Contributor

selik left a comment

Yep, didn't realize my name had been misspelled.
@csabella
csabella approved these changes Jan 25, 2020
View changes
@csabella csabella merged commit 9bfb4a7 into python:master Jan 25, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200124.44 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 25, 2020

Thanks @fireattack for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 25, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 25, 2020

Thanks @fireattack for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
@fireattack @miss-islington
Update 3.8.rst (pythonGH-18173)
7a95960 
Fixed the name of the contributor (@selik).
(cherry picked from commit 9bfb4a7)

Co-authored-by: fireattack <human.peng@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 25, 2020

GH-18182 is a backport of this pull request to the 3.8 branch.
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor

csabella commented Jan 25, 2020

@fireattack, thanks for catching that and for making the PR!
csabella added a commit that referenced this pull request Jan 25, 2020
@miss-islington @fireattack @csabella
Update 3.8.rst (GH-18173) (#18182)
Loading status checks…
079dfe0 
Fixed the name of the contributor (@selik).
(cherry picked from commit 9bfb4a7)

Co-authored-by: fireattack <human.peng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selik selik

@csabella csabella

Assignees
No one assigned
Labels
CLA not signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@fireattack @the-knights-who-say-ni @miss-islington @bedevere-bot @csabella @selik
You can’t perform that action at this time.