A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

We can't make this change, as it means the statics get initialised before the Python interpreter has been initialised, and won't be reinitialised if the interpreter is destroyed and recreated.

My apologies, my comment above was based on an outdated understanding of how the identifier structs get initialised (it's the usage that initialises them, not the declaration).

That means this is a useful refactoring to help identify blockers to full subinterpreter support.

I have made the requested changes; please review again

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

Codecov Report

Merging #18254 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #18254    +/-   ##
========================================
  Coverage   82.11%   82.12%            
========================================
  Files        1954     1954            
  Lines      583213   583366   +153     
  Branches    44383    44401    +18     
========================================
+ Hits       478932   479092   +160     
+ Misses      94652    94636    -16     
- Partials     9629     9638     +9     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10355ed...98e1fb3. Read the comment docs.

Thanks, @shihai1991 !