Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Update 3.8.rst (GH-18173) #18182

Merged
merged 1 commit into from Jan 25, 2020
Merged

[3.8] Update 3.8.rst (GH-18173) #18182

merged 1 commit into from Jan 25, 2020

Conversation

@miss-islington
Copy link

miss-islington commented Jan 25, 2020

Fixed the name of the contributor (@selik).
(cherry picked from commit 9bfb4a7)

Co-authored-by: fireattack human.peng@gmail.com
@fireattack @miss-islington
Update 3.8.rst (GH-18173)
Loading status checks…
7a95960 
Fixed the name of the contributor (@selik).
(cherry picked from commit 9bfb4a7)

Co-authored-by: fireattack <human.peng@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jan 25, 2020
Merged
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 25, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@fireattack

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@csabella
csabella approved these changes Jan 25, 2020
View changes
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 25, 2020

@fireattack and @csabella: Status check is done, and it's a success ✅ .
@csabella csabella merged commit 079dfe0 into python:3.8 Jan 25, 2020
6 checks passed
6 checks passed
Docs
Details
Azure Pipelines PR #20200125.17 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 25, 2020

@csabella: Please replace # with GH- in the commit message next time. Thanks!
@miss-islington miss-islington deleted the miss-islington:backport-9bfb4a7-3.8 branch Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

Assignees
No one assigned
Labels
CLA not signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@miss-islington @the-knights-who-say-ni @bedevere-bot @csabella @fireattack
You can’t perform that action at this time.