Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.8] Minor C API documentation improvements. (GH-17696) #17697
Conversation
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without: ``` warning: using the result of an assignment as a condition without parentheses [-Wparentheses] ``` The other change is a typo fix (cherry picked from commit 5c7ed75) Co-authored-by: William Ayd <william.ayd@icloud.com>
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 25, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This comment has been minimized.
This comment has been minimized.
|
@WillAyd and @benjaminp: Status check is done, and it's a success |
miss-islington commentedDec 25, 2019
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
The other change is a typo fix
(cherry picked from commit 5c7ed75)
Co-authored-by: William Ayd william.ayd@icloud.com