Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39439: Fix Multiprocessing Python Path in Windows Virtualenv #18158

Merged
merged 2 commits into from Jan 28, 2020
Merged

bpo-39439: Fix Multiprocessing Python Path in Windows Virtualenv #18158

merged 2 commits into from Jan 28, 2020

Conversation

@ameily
Copy link
Contributor

ameily commented Jan 24, 2020 •
edited by bedevere-bot

Honor the Python path when a virtualenv is active on Windows.

https://bugs.python.org/issue39439
@ameily
revert change to use sys.executable when not running as a service
Loading status checks…
036a3f6
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
815ee6a
@csabella csabella requested a review from zooba Jan 27, 2020
@zooba zooba merged commit 0be3246 into python:master Jan 28, 2020
11 checks passed
11 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200124.9 succeeded
Details
bedevere/issue-number Issue number 39439 found
Details
bedevere/news News entry found in Misc/NEWS.d
codecov/patch 100.00% of diff hit (target 82.10%)
Details
codecov/project 83.18% (+1.07%) compared to 65ecc39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 28, 2020

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 28, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 28, 2020

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 28, 2020
@ameily @miss-islington
bpo-39439: Fix multiprocessing spawn path in a venv on Windows (pytho…
e5e34c6 
…nGH-18158)

(cherry picked from commit 0be3246)

Co-authored-by: Adam Meily <ameily@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 28, 2020

GH-18237 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 28, 2020

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 28, 2020

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 28, 2020
@ameily @miss-islington
bpo-39439: Fix multiprocessing spawn path in a venv on Windows (pytho…
5bd8c92 
…nGH-18158)

(cherry picked from commit 0be3246)

Co-authored-by: Adam Meily <ameily@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 28, 2020

GH-18238 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 28, 2020
@miss-islington @ameily
bpo-39439: Fix multiprocessing spawn path in a venv on Windows (GH-18158
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dbb37aa 
)

(cherry picked from commit 0be3246)

Co-authored-by: Adam Meily <ameily@users.noreply.github.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ameily @shihai1991
bpo-39439: Fix multiprocessing spawn path in a venv on Windows (pytho…
8bf732f 
…nGH-18158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees
No one assigned
Labels
CLA signed needs backport to 3.7
Projects
None yet
Milestone
No milestone
6 participants
@ameily @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni @csabella
You can’t perform that action at this time.