Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39482: Add a fixer to handling abstract base classes #18245

Open
wants to merge 2 commits into
base: master
from
Open

bpo-39482: Add a fixer to handling abstract base classes #18245

wants to merge 2 commits into from
+114 −0

Conversation

@corona10
Copy link
Member

corona10 commented Jan 29, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39482
@corona10 corona10 requested a review from rhettinger as a code owner Jan 29, 2020
@corona10 corona10 changed the title bpo-39842: WIP add fix_collections_import.py bpo-39842: [WIP] add fix_collections_import.py Jan 29, 2020
@corona10 corona10 force-pushed the corona10:bpo-39482 branch from 2e14625 to 71b917a Jan 29, 2020
@corona10 corona10 changed the title bpo-39842: [WIP] add fix_collections_import.py bpo-39482: [WIP] add fix_collections_import.py Jan 29, 2020
@corona10 corona10 force-pushed the corona10:bpo-39482 branch from 71b917a to bb3a988 Jan 29, 2020
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 29, 2020 •
edited

Codecov Report

Merging #18245 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18245       +/-   ##
===========================================
+ Coverage   82.12%   83.19%    +1.07%     
===========================================
  Files        1955     1571      -384     
  Lines      588711   414280   -174431     
  Branches    44382    44412       +30     
===========================================
- Hits       483452   344670   -138782     
+ Misses      95631    59968    -35663     
- Partials     9628     9642       +14
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 442 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a65eba...6aac871. Read the comment docs.
@corona10 corona10 force-pushed the corona10:bpo-39482 branch 3 times, most recently from aec65cf to 7cec2fa Jan 29, 2020
@corona10 corona10 changed the title bpo-39482: [WIP] add fix_collections_import.py bpo-39482: Add a fixer to handling abstract base classes Jan 29, 2020
@corona10 corona10 removed the DO-NOT-MERGE label Jan 29, 2020
@corona10 corona10 requested review from vstinner, tirkarthi and benjaminp Jan 29, 2020
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member Author

corona10 commented Jan 29, 2020 •
edited

@tirkarthi @benjimin @vstinner @rhettinger

Dear core developers,
Please take a look and is it good to add news for 3.9?
@corona10 corona10 force-pushed the corona10:bpo-39482 branch from 6aac871 to cbdd726 Jan 30, 2020
corona10 added 2 commits Jan 29, 2020
@corona10
bpo-39482: Add a fixer to handling abstract base classes
b2fb988
@corona10
bpo-39482: Update unittest
Loading status checks…
775aa18
@corona10 corona10 force-pushed the corona10:bpo-39482 branch from cbdd726 to 775aa18 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@benjaminp benjaminp

@rhettinger rhettinger

@tirkarthi tirkarthi

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@corona10 @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.