break a reference cycle in the C Pickler

test that stale pickled object are well gc'ed
📜🤖 Added by blurb_it.
python · pierreglaser · pierreglaser · pierreglaser · Jan 30, 2020 · pierreglaser
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
    self->framing = 0;
-    return 0;
+    Py_CLEAR(self->reducer_override);
diff --git a/Lib/test/pickletester.py b/Lib/test/pickletester.py
+                    pass
+
+                collect = threading.Event()
+                _ = weakref.ref(f, lambda obj: collect.set())
diff --git a/Lib/test/pickletester.py b/Lib/test/pickletester.py
@@ -3499,6 +3499,37 @@ class MyClass:
                        ValueError, 'The reducer just failed'):
                    p.dump(h)

+    def test_reducer_override_no_reference_cycle(self):
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
+    if (0) {
+  error:
+        status = -1;
+    }