Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesBe more specific about the `.so` gitignore patterns #17328
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
I don't know if separate the entry on .gitignore is a good idea.
|
This comment has been minimized.
This comment has been minimized.
@eamanu please see the linked discussion -- thanks! |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Nov 27, 2019
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Nov 27, 2019
|
Sorry @asottile and @zware, I had trouble checking out the |
jacobneiltaylor
added a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
In pythonGH-15823 the pattern was changed from `libpython*.so*` to `*.so*` which matches a bit too greedily for some packagers. For instance this trips up `debian/README.source`. A more specific pattern fixes this issue.
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
In pythonGH-15823 the pattern was changed from `libpython*.so*` to `*.so*` which matches a bit too greedily for some packagers. For instance this trips up `debian/README.source`. A more specific pattern fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asottile commentedNov 21, 2019
In #15823 the pattern was changed from
libpython*.so*to*.so*whichmatches a bit too greedily for some packagers. For instance this trips up
debian/README.source. A more specific pattern fixes this issue.