bpo-38937: exec lines from .pth files in a copy of the site.py globals #17414
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
@chrisjbillington, please address the code review request to add a test. Thank you! |
|
Apologies for the delay and thanks for reviewing. I've added a test, and verified that it fails without the change and passes with the change. |
|
Pipeline failure appears unrelated, if I'm understanding correctly. |
Each line of a
.pthfile isexec()'d in its own namespace, which is a copy of thesitemodule's global namespace. It's a copy so that the code in.pthfiles can't actually modify thesitemodule just by defining a variable (previously it could!), and it's the globals of thesitemodule rather than an empty dict in order to be backward compatible with.pthfiles that may be using some of those globals likesysoroswithout explicitly importing them.Each line gets its own copy of the namespace, so the lines can't use each other's variables, preserving the deliberate limitation that code in
.pthfiles is limited to one line.https://bugs.python.org/issue38937