Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39374: Updated sorting documentation with better key function description #18177
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Jan 25, 2020
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I approve either as is, with (...) added twice, or with it added only once. Raymond, do you have a preference? I will merge if you want. |
This comment has been minimized.
This comment has been minimized.
|
@brandfilt Please sign CLA if you have not. It is really easy. I believe we can merge this without, but 'with' is easier, and we would be set for your next PR. |
This comment has been minimized.
This comment has been minimized.
|
@terryjreedy I added my GitHub name to bugs.python.org details and signed the CLA after creating the pull request |
This comment has been minimized.
This comment has been minimized.
|
Thanks. It takes a working day for it to get recorded properly. |
This comment has been minimized.
This comment has been minimized.
|
The Azure Pipeline seems to be stuck. Closing and reopening this PR in an attempt to restart it. |
brandfilt commentedJan 25, 2020
•
edited by terryjreedy
https://bugs.python.org/issue39374