Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39494: Remove extra null terminators from kwlist variables #18267

Merged
merged 1 commit into from Jan 30, 2020
Merged

bpo-39494: Remove extra null terminators from kwlist variables #18267

merged 1 commit into from Jan 30, 2020
+3 −3

Conversation

@alexhenrie
Copy link
Contributor

alexhenrie commented Jan 30, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39494
@alexhenrie
bpo-39494: Remove extra null terminators from kwlist variables
Loading status checks…
53f703c
@alexhenrie alexhenrie requested a review from berkerpeksag as a code owner Jan 30, 2020
@berkerpeksag
berkerpeksag approved these changes Jan 30, 2020
View changes
Copy link
Member

berkerpeksag left a comment

LGTM, thanks!
@berkerpeksag berkerpeksag merged commit 188bb5b into python:master Jan 30, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200130.10 succeeded
Details
bedevere/issue-number Issue number 39494 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 30, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora 3.x has failed when building commit 188bb5b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/11/builds/265) and take a look at the build logs.
  4. Check if the failure is related to this commit (188bb5b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/11/builds/265

Failed tests:

  • test_largefile

Failed subtests:

  • test_it - test.test_largefile.TestCopyfile
  • test_it - test.test_largefile.TestSocketSendfile

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

406 tests OK.

10 slowest tests:

  • test_multiprocessing_spawn: 2 min 49 sec
  • test_concurrent_futures: 2 min 45 sec
  • test_tokenize: 2 min 23 sec
  • test_unparse: 2 min 18 sec
  • test_capi: 2 min 4 sec
  • test_multiprocessing_forkserver: 1 min 41 sec
  • test_lib2to3: 1 min 36 sec
  • test_unicodedata: 1 min 19 sec
  • test_asyncio: 1 min 15 sec
  • test_multiprocessing_fork: 1 min 13 sec

1 test failed:
test_largefile

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_largefile

Total duration: 23 min 6 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 195, in run
    f.write(chunk)
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 209, in test_it
    client.sendfile(f)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/socket.py", line 483, in sendfile
    return self._sendfile_use_sendfile(file, offset, count)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/socket.py", line 400, in _sendfile_use_sendfile
    raise err from None
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/socket.py", line 386, in _sendfile_use_sendfile
    sent = os_sendfile(sockno, fileno, offset, blocksize)
BrokenPipeError: [Errno 32] Broken pipe


Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/threading.py", line 944, in _bootstrap_inner
    self.run()
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/threading.py", line 882, in run
    self._target(*self._args, **self._kwargs)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 195, in run
    f.write(chunk)
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 161, in test_it
    shutil.copyfile(TESTFN, TESTFN2)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 270, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
OSError: [Errno 28] No space left on device: '@test_142920_tmp' -> '@test_142920_tmp2'


Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 161, in test_it
    shutil.copyfile(TESTFN, TESTFN2)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 270, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
OSError: [Errno 28] No space left on device: '@test_140721_tmp' -> '@test_140721_tmp2'
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@alexhenrie @shihai1991
bpo-39494: Remove extra null terminators from kwlist vars (pythonGH-1…
f533ccd 
…8267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@alexhenrie @bedevere-bot @berkerpeksag @the-knights-who-say-ni
You can’t perform that action at this time.