Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36239: Skip comments in gettext infos #12255

Merged
merged 2 commits into from
May 9, 2019
Merged

bpo-36239: Skip comments in gettext infos #12255

merged 2 commits into from
May 9, 2019

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Mar 9, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka self-requested a review March 10, 2019 12:50
vstinner
vstinner approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but IMHO the change deserves a few more comments :-)

Lib/gettext.py Show resolved Hide resolved
Lib/test/test_gettext.py Show resolved Hide resolved
@JulienPalard JulienPalard reopened this May 8, 2019
@JulienPalard JulienPalard merged commit afd1e6d into python:master May 9, 2019
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2019
@JulienPalard @miss-islington
bpo-36239: Skip comments in gettext infos (pythonGH-12255)
a8dfa2f 
(cherry picked from commit afd1e6d)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link

GH-13218 is a backport of this pull request to the 3.7 branch.

@JulienPalard JulienPalard deleted the gettext-comments branch June 16, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JulienPalard @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni