bpo-34185: Fix test module collision in test_bdb when ran as script #8537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running test_bdb.py as a script, `import test_module` would be
importing the existing Lib/test/test_modules.py instead of the
tempcwd/test_module.py module which was dynamically created by
test_bdb.py itself.
Indeed, when running `./python Lib/test/test_bdb.py` ("as a script"),
`sys.path[0]` is getting filled with the path to Lib/test.
The chosen solution here was to change the name of the temporary module
created by test_bdb.py .
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request You can check yourself Thanks again for your contribution, we look forward to reviewing it! |
serhiy-storchaka
added
needs backport to 3.6
needs backport to 3.7
and removed
CLA not signed
labels
serhiy-storchaka
approved these changes
Dec 5, 2018
|
Thanks @lajarre for the PR, and @serhiy-storchaka for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…ythonGH-8537) When running test_bdb.py as a script, `import test_module` would be importing the existing Lib/test/test_modules.py instead of the tempcwd/test_module.py module which was dynamically created by test_bdb.py itself. (cherry picked from commit 54fd455) Co-authored-by: Alex H <1884912+lajarre@users.noreply.github.com>
|
GH-10935 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…ythonGH-8537) When running test_bdb.py as a script, `import test_module` would be importing the existing Lib/test/test_modules.py instead of the tempcwd/test_module.py module which was dynamically created by test_bdb.py itself. (cherry picked from commit 54fd455) Co-authored-by: Alex H <1884912+lajarre@users.noreply.github.com>
|
GH-10936 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…ythonGH-8537) When running test_bdb.py as a script, `import test_module` would be importing the existing Lib/test/test_modules.py instead of the tempcwd/test_module.py module which was dynamically created by test_bdb.py itself. (cherry picked from commit 54fd455) Co-authored-by: Alex H <1884912+lajarre@users.noreply.github.com>
|
GH-10937 is a backport of this pull request to the 2.7 branch. |
|
Thank you for your contribution @lajarre! |
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
…H-8537) When running test_bdb.py as a script, `import test_module` would be importing the existing Lib/test/test_modules.py instead of the tempcwd/test_module.py module which was dynamically created by test_bdb.py itself. (cherry picked from commit 54fd455) Co-authored-by: Alex H <1884912+lajarre@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
…H-8537) When running test_bdb.py as a script, `import test_module` would be importing the existing Lib/test/test_modules.py instead of the tempcwd/test_module.py module which was dynamically created by test_bdb.py itself. (cherry picked from commit 54fd455) Co-authored-by: Alex H <1884912+lajarre@users.noreply.github.com>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 5, 2018
…H-8537) (GH-10936) When running test_bdb.py as a script, `import test_module` would be importing the existing Lib/test/test_modules.py instead of the tempcwd/test_module.py module which was dynamically created by test_bdb.py itself. (cherry picked from commit 54fd455) Co-authored-by: Alex H <1884912+lajarre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When running test_bdb.py as a script,
import test_modulewould beimporting the existing Lib/test/test_modules.py instead of the
tempcwd/test_module.py module which was dynamically created by
test_bdb.py itself.
Indeed, when running
./python Lib/test/test_bdb.py("as a script"),sys.path[0]is getting filled with the path to Lib/test.The chosen solution here was to change the name of the temporary module
created by test_bdb.py .
https://bugs.python.org/issue34185