Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39350: Fix regression introduced when fractions.gcd was removed #18309
+24
−0
Conversation
This comment has been minimized.
This comment has been minimized.
The broken code made it to 3.9.0a3. That's how I have discovered the regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mdickinson commentedFeb 2, 2020
•
edited by bedevere-bot
This PR is a quick fix for the breakage introduced in #18021, which removed the
_gcdfunction while the core code was still using it.Possibly the behaviour of
Fractionfor non-integers should be different, but I think it makes sense to fix the breakage immediately and then discuss whether we want to make behavioural changes.No news entry needed, because the broken code hasn't make it into any release or prerelease.
https://bugs.python.org/issue39350