Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39440: Update sum comment. #18240
Merged
+5
−1
Conversation
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
@mdickinson, are you able to merge this for me? |
This comment has been minimized.
This comment has been minimized.
Sorry, yes. Will do. |
mdickinson
merged commit abb9a44
into
python:master
12 checks passed
12 checks passed
bedevere/news
"skip news" label found
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 1, 2020
|
@mdickinson: Please replace |
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brandtbucher commentedJan 28, 2020
•
edited by bedevere-bot
Broken
sum-speedup ideas have surfaced twice over the last few days. At least one was based on this comment, which leads contributors to believe that using in-place addition for later iterations should be fine.I'm just updating the comment with a link to the previous discussion to avoid further confusion and misguided efforts.
https://bugs.python.org/issue39440