Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38830: Correct slot signature in Qt example. #17220

Merged
merged 1 commit into from Nov 18, 2019
Merged

bpo-38830: Correct slot signature in Qt example. #17220

merged 1 commit into from Nov 18, 2019

Conversation

vsajip
Copy link
Member

@vsajip vsajip commented Nov 18, 2019 •
edited by bedevere-bot

@vsajip vsajip added docs Documentation in the Doc dir skip news labels Nov 18, 2019
@vsajip vsajip self-assigned this Nov 18, 2019
@vsajip vsajip merged commit 5383956 into python:master Nov 18, 2019
@vsajip vsajip deleted the fix-38830 branch Nov 18, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2019

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2019

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2019

Sorry, @vsajip, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5383956583bb758f3828513bcdd011871f24a0e8 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2019

Sorry @vsajip, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5383956583bb758f3828513bcdd011871f24a0e8 3.8

@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2019

GH-17221 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2019

GH-17222 is a backport of this pull request to the 3.7 branch.

vsajip added a commit that referenced this pull request Nov 18, 2019
@vsajip
[3.8] bpo-38830: Correct slot signature in Qt example. (GH-17220) (GH…
21eb731 
…-17221)

(cherry picked from commit 5383956)
vsajip added a commit that referenced this pull request Nov 18, 2019
@vsajip
[3.7] bpo-38830: Correct slot signature in Qt example. (GH-17220) (GH…
9a4c5c3 
…-17222)

(cherry picked from commit 5383956)
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vsajip
bpo-38830: Correct slot signature in Qt example. (pythonGH-17220)
9f5aead
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vsajip @shihai1991
bpo-38830: Correct slot signature in Qt example. (pythonGH-17220)
f30e572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsajip vsajip

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsajip @miss-islington @bedevere-bot @the-knights-who-say-ni