Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39388: IDLE: Fix bug when cancelling out of configdialog #18068

Merged
merged 5 commits into from Jan 25, 2020
Merged

bpo-39388: IDLE: Fix bug when cancelling out of configdialog #18068

merged 5 commits into from Jan 25, 2020
+19 −8

Conversation

@csabella
Copy link
Contributor

csabella commented Jan 19, 2020 •
edited by bedevere-bot

Changes to keybindings were being remembered even when cancelling out of the Config Dialog.

https://bugs.python.org/issue39388
@csabella
bpo-39388: Fix bug when cancelling out of configdialog
Loading status checks…
6f0e12b
@csabella csabella requested a review from terryjreedy as a code owner Jan 19, 2020
@csabella csabella changed the title bpo-39388: Fix bug when cancelling out of configdialog bpo-39388: IDLE: Fix bug when cancelling out of configdialog Jan 19, 2020
@terryjreedy
terryjreedy reviewed Jan 25, 2020
View changes
Copy link
Member

terryjreedy left a comment

A 2nd button bug not caught by missing tests. We wrote changes.clear to be called at this spot. (It is not called anywhere else.) I will add a test that changes is cleared and add news items.
terryjreedy added 3 commits Jan 25, 2020
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_18068
93196de
@terryjreedy
Add new test.
80dc438
@terryjreedy
News items.
Loading status checks…
a9a1821
@terryjreedy
terryjreedy approved these changes Jan 25, 2020
View changes
@terryjreedy
Change '__main__' to __name__ to work on all systems.
Loading status checks…
1ff8739
@terryjreedy terryjreedy merged commit d0d9fa8 into python:master Jan 25, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200125.9 succeeded
Details
bedevere/issue-number Issue number 39388 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 25, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
@csabella @miss-islington
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonG…
6cb1d80 
…H-18068)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 25, 2020

GH-18178 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
@csabella @miss-islington
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonG…
6065b6e 
…H-18068)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 25, 2020

GH-18179 is a backport of this pull request to the 3.7 branch.
sthagen added a commit to sthagen/cpython that referenced this pull request Jan 25, 2020
@sthagen
Merge pull request #207 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
21dc636 
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonGH-18068)
miss-islington added a commit that referenced this pull request Jan 25, 2020
@miss-islington @csabella
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a234492 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 25, 2020
@miss-islington @csabella
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd9ce2b 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

csabella commented Jan 25, 2020

I had some additional test for configdialog in GH-3592 and I rebased it last week. It's not all the missing tests.
@csabella csabella deleted the csabella:cancelconfig branch Jan 25, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@csabella @terryjreedy @shihai1991
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonG…
f837254 
…H-18068)


Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
5 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni
You can’t perform that action at this time.