Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38506: Fix the Windows launcher's mishandling of 3.10 #18307
+6
−2
Conversation
This comment has been minimized.
This comment has been minimized.
|
This may not be the proper fix. If this approach is accepted, this PR would still need a news entry. |
This comment has been minimized.
This comment has been minimized.
|
@ZackerySpytz Using the API is the best choice, IMHO, but rather than using the "clever" subtraction approach, let's just use direct comparisons and return -1, 0 or 1. This isn't a tight loop, so readability wins over number of steps. |
This comment has been minimized.
This comment has been minimized.
|
Oh, we probably also want an invariant or neutral locale rather than the current user locale, as we're sorting our own values rather than user-specified values. I don't remember which constant that would be though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ZackerySpytz commentedFeb 2, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue38506