Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added __len__ method to _BaseNetwork class in ipaddress module. #18308

Open
wants to merge 1 commit into
base: master
from

Conversation

@mfabryz
Copy link

mfabryz commented Feb 2, 2020

This enables a call such as:

In [41]: random.choice(ipaddress.ip_network("192.169.0.0/16")) Out[41]: IPv4Address('192.169.242.248')

This enables a call such as random.choice(ipaddress.ip_network("192.169.0.0/16")).
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Feb 2, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mfabryz

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella

This comment has been minimized.

Copy link
Contributor

csabella commented Feb 2, 2020

Hi @mfabryz, thank you for your interest in improving CPython. Any feature request would require an issue to be opened on out bug tracker. Please take a look at this page from the devguide for more info. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.