Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39492: Fix a reference cycle between reducer_override and a Pickler instance #18266

Merged
merged 5 commits into from Feb 2, 2020
Merged

bpo-39492: Fix a reference cycle between reducer_override and a Pickler instance #18266

merged 5 commits into from Feb 2, 2020
+43 −4

Conversation

@pierreglaser
Copy link
Contributor

pierreglaser commented Jan 30, 2020 •
edited by miss-islington

This also needs a backport to 3.8

https://bugs.python.org/issue39492

Automerge-Triggered-By: @pitrou
@pierreglaser
break a reference cycle in the C Pickler
e6e1fca
@pierreglaser
test that stale pickled object are well gc'ed
Loading status checks…
9b2bc39
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eaf3e55
@pierreglaser pierreglaser mentioned this pull request Jan 30, 2020
Open
@pierreglaser

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

pierreglaser commented Jan 31, 2020

@pitrou if you want to take a look.
@pitrou
pitrou requested changes Feb 1, 2020
View changes
Copy link
Member

pitrou left a comment

Thank you for noticing and for the fix.
Modules/_pickle.c Show resolved Hide resolved
Lib/test/pickletester.py Outdated Show resolved Hide resolved
Lib/test/pickletester.py Show resolved Hide resolved
Modules/_pickle.c Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 1, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
pierreglaser added 2 commits Feb 2, 2020
@pierreglaser
simplifications, comments
d526584
@pierreglaser
Merge branch 'fix-pickler-reference-cycle' of github.com:pierreglaser…
Loading status checks…
eca89b4 
…/cpython into fix-pickler-reference-cycle
@pitrou
pitrou approved these changes Feb 2, 2020
View changes
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 2, 2020

@pierreglaser: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 0f2f35e into python:master Feb 2, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200202.27 succeeded
Details
bedevere/issue-number Issue number 39492 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 2, 2020

Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@pierreglaser pierreglaser deleted the pierreglaser:fix-pickler-reference-cycle branch Feb 2, 2020
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 2, 2020

Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 2, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 2, 2020

Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 2, 2020

GH-18316 is a backport of this pull request to the 3.8 branch.
pitrou added a commit that referenced this pull request Feb 2, 2020
@pitrou @pierreglaser
[3.8] bpo-39492: Fix a reference cycle between reducer_override and a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1723687 
… Pickler instance (GH-18266) (#18316)

https://bugs.python.org/issue39492

Automerge-Triggered-By: @pitrou
(cherry picked from commit 0f2f35e)

Co-authored-by: Pierre Glaser <pierreglaser@msn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou

Assignees
No one assigned
Labels
🤖 automerge CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@pierreglaser @bedevere-bot @miss-islington @pitrou @the-knights-who-say-ni
You can’t perform that action at this time.