Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes in sorting descriptions #18317
Conversation
- merge_collapse isn't always about merging the new run with preceding runs. For example [64, 32, 65] (where 65 is the new run) becomes [96, 65] by merging only the preceding runs and not merging the new run. - It's not just called to "see whether it should merge" but also to actually merge.
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Feb 2, 2020
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Looks good! Thank you |
pochmann commentedFeb 2, 2020
Improvements in listsort.txt and a comment in sortperf.py.