Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39424: Fix the call method. #18277

Merged

Conversation

@damani42
Copy link
Contributor

damani42 commented Jan 30, 2020

The method assertRaisesRegexp is deprecated use assertRaisesRegex
instead.

https://bugs.python.org/issue39424

The method assertRaisesRegexp is deprecated use assertRaisesRegex
instead.
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 30, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@damani42

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@4383
4383 approved these changes Jan 30, 2020
Copy link
Contributor

4383 left a comment

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 38c878b into python:master Jan 30, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200130.31 succeeded
Details
bedevere/issue-number Issue number 39424 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner

This comment has been minimized.

Copy link
Member

vstinner commented Jan 30, 2020

@serhiy-storchaka: This change has been merged whereas the CLA was not signed. But it's a trivial change, so I don't think that it matters. Moreover, I'm in touch with @damani42 who told me that he is going to sign the CLA (right me, he didn't get the confirmation email of the creation of his bugs.python.org account).

@serhiy-storchaka

This comment has been minimized.

Copy link
Member

serhiy-storchaka commented Jan 30, 2020

Yes, I merged it because it was trivial. If not @damani42 somebody other would provide an identical PR in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.