bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT #17231
Conversation
|
LGTM I also double-checked that after this PR there are no usages of the macro left. One question and a minor code suggestion for the NEWS file: Do you want to left the empty macro in |
Misc/NEWS.d/next/Core and Builtins/2019-11-18-16-37-49.bpo-38835.-U4se1.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Core and Builtins/2019-11-18-16-37-49.bpo-38835.-U4se1.rst
Outdated
Show resolved
Hide resolved
|
We don't provide any contract regarding these macros and I don't see a way a user can override them easily so I don't think we should be concerned with that. |
If someone wants to remove them, I would suggest to first deprecate them, and wait at least one Python release before removing them. And do that in a separated issue: https://bugs.python.org/issue38835 title is "pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API", it's not directly related :-) |
The PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty: they have been doing nothing for the last year (since commit 735ae8d), so stop using them.
|
I updated the NEWS entry. I rebased the PR to be able to modify the commit message (copy of the NEWS entry). |
I think the only way to get non-empty macros is to modify pyfpe.h. I doubt anyone does that. |
…nGH-17231) The PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty: they have been doing nothing for the last year (since commit 735ae8d), so stop using them.
…nGH-17231) The PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty: they have been doing nothing for the last year (since commit 735ae8d), so stop using them.
PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty: they
do nothing for one year (since commit
735ae8d), stop using them.
https://bugs.python.org/issue38835