Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39496: Remove redundant checks from sqlite module's while loops #18270

Merged
merged 1 commit into from Feb 1, 2020
Merged

bpo-39496: Remove redundant checks from sqlite module's while loops #18270

merged 1 commit into from Feb 1, 2020
+6 −20

Conversation

@alexhenrie
Copy link
Contributor

alexhenrie commented Jan 30, 2020 •
edited by bedevere-bot

This is a big win for code readability and it could also help performance.

https://bugs.python.org/issue39496
@alexhenrie alexhenrie requested a review from berkerpeksag as a code owner Jan 30, 2020
@alexhenrie alexhenrie force-pushed the alexhenrie:sqlite-loops branch 3 times, most recently from 46a8b59 to 62e0b0f Jan 30, 2020
@alexhenrie alexhenrie changed the title bpo-39496: Replace while loops with for loops to avoid redundant checks bpo-39496: Remove redundant checks from sqlite module's while loops Feb 1, 2020
@alexhenrie
bpo-39496: Remove redundant checks from sqlite module's while loops
Loading status checks…
8344dc8
@alexhenrie alexhenrie force-pushed the alexhenrie:sqlite-loops branch from 62e0b0f to 8344dc8 Feb 1, 2020
@berkerpeksag
berkerpeksag approved these changes Feb 1, 2020
View changes
Copy link
Member

berkerpeksag left a comment

LGTM, thanks!
@berkerpeksag berkerpeksag merged commit 78c7183 into python:master Feb 1, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200201.15 succeeded
Details
bedevere/issue-number Issue number 39496 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
petdance added a commit to petdance/cpython that referenced this pull request Feb 2, 2020
@alexhenrie @petdance
bpo-39496: Remove redundant checks from _sqlite/cursor.c (pythonGH-18270
12d1221 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@alexhenrie @berkerpeksag @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.