Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39573: Clean up modules and headers to use Py_IS_TYPE #18521

Merged
merged 3 commits into from Feb 17, 2020
Merged

bpo-39573: Clean up modules and headers to use Py_IS_TYPE #18521

merged 3 commits into from Feb 17, 2020
+56 −56

Conversation

@corona10
Copy link
Member

corona10 commented Feb 16, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39573
@corona10
bpo-39573: Clean up modules and headers to use Py_IS_TYPE
Loading status checks…
cea3179
@corona10 corona10 added the skip news label Feb 16, 2020
@corona10
bpo-39573: Lint
Loading status checks…
2c4ce0f
@corona10 corona10 requested a review from vstinner Feb 16, 2020
@vstinner
vstinner requested changes Feb 17, 2020
View changes
Copy link
Member

vstinner left a comment

Please don't use git rebase, just add a commit, to ease review ;-) This PR is long to review.
Objects/typeobject.c Outdated
@@ -302,7 +302,7 @@ type_mro_modified(PyTypeObject *type, PyObject *bases) {
each subclass when their mro is recursively updated.
*/
Py_ssize_t i, n;
int custom = (Py_TYPE(type) != &PyType_Type);
int custom = Py_IS_TYPE(type, &PyType_Type);

This comment has been minimized.

Sign in to view
Copy link
@vstinner

vstinner Feb 17, 2020

Member

This one looks wrong.

This comment has been minimized.

Sign in to view
Copy link
@corona10

corona10 Feb 17, 2020

Author Member

Oh.. good catch!

This comment has been minimized.

Sign in to view
Copy link
@vstinner

vstinner Feb 17, 2020

Member

I know that you made this mistake on purpose. Just to check that I really review your PRs! :-)

This comment has been minimized.

Sign in to view
Copy link
@corona10

corona10 Feb 17, 2020

Author Member

lol :)
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 17, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@corona10
bpo-39573: Fix mistake
Loading status checks…
99ed0fd
@vstinner
vstinner approved these changes Feb 17, 2020
View changes
Copy link
Member

vstinner left a comment

LGTM.
@vstinner vstinner merged commit 1b55b65 into python:master Feb 17, 2020
7 of 8 checks passed
7 of 8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200217.17 succeeded with issues
Details
bedevere/issue-number Issue number 39573 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
61c495a 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
56ca767 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
2864b57 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
5fb7539 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
9e327f8 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
e4441dd 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
f085e14 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
3af30f0 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
bb7dc64 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
da7e84e 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
b7350e5 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
c76806d 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
e2bb1b7 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
f6dd02e 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
25fbb87 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
ff2f484 
…ythonGH-18521)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Clean up modules and headers to use Py_IS_TYPE() function (p…
8e03a8c 
…ythonGH-18521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@corona10 @bedevere-bot @vstinner @the-knights-who-say-ni
You can’t perform that action at this time.