bpo-35885: configparser indent #18522

idomic · 2020-02-16T17:32:31Z

bpo-35885: configparser indent

https://bugs.python.org/issue35885

Co-Authored-By: Victor Stinner <vstinner@python.org>

…mic/cpython into bpo-35885-configparserIndent

idomic · 2020-02-23T01:51:02Z

Adding @taleinat

codecov · 2020-02-23T02:01:07Z

Codecov Report

Merging #18522 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18522      +/-   ##
==========================================
- Coverage   82.20%   82.07%   -0.13%     
==========================================
  Files        1958     1955       -3     
  Lines      589743   584080    -5663     
  Branches    44457    44458       +1     
==========================================
- Hits       484772   479364    -5408     
+ Misses      95308    95089     -219     
+ Partials     9663     9627      -36

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Modules/_decimal/libmpdec/umodarith.h	`80.76% <0.00%> (-19.24%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-12.86%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.87%)`	⬇️
... and 340 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33bdbb...9b57c26. Read the comment docs.

taleinat · 2020-02-23T08:25:36Z

Lib/configparser.py

        Write the configuration state in .ini format. If
        `space_around_delimiters' is True (the default), delimiters
        between keys and values are surrounded by spaces.
+
+        If `indent' is empty (the default), the keys won't be indented.


This doc-string needs to mention what will happen when indent is set to a non-empty value.

taleinat · 2020-02-23T08:26:29Z

Misc/NEWS.d/next/Library/2020-02-16-17-38-33.bpo-35885.VijyzZ.rst

@@ -0,0 +1,3 @@
+:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.


Suggested change

:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.

Add a new parameter ``indent`` to :meth:`configparser.write()`.

taleinat · 2020-02-23T08:47:29Z

Misc/NEWS.d/next/Library/2020-02-16-17-38-33.bpo-35885.VijyzZ.rst

@@ -0,0 +1,3 @@
+:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.
+When indent is set, the parser will indent the lines according to the given input value.


IMO this is too much information for the NEWS entry, but something like this should be added to the doc-string.

taleinat · 2020-02-23T08:47:44Z

Misc/NEWS.d/next/Library/2020-02-16-17-38-33.bpo-35885.VijyzZ.rst

@@ -0,0 +1,3 @@
+:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.
+When indent is set, the parser will indent the lines according to the given input value.
+Contributed by Ido Michael in :issue:`35885`


Suggested change

Contributed by Ido Michael in :issue:`35885`

Contributed by Ido Michael.

bedevere-bot · 2020-02-23T08:48:00Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

taleinat · 2020-02-23T08:58:35Z

@idomic, something with how you're managing your PR branches is very problematic. Would you mind closing this PR and opening a new, clean one?

idomic and others added 6 commits February 13, 2020 17:56

Hard reset + cherry piciking the changes.

13c5b05

📜🤖 Added by blurb_it.

fdecdf0

Added @vstinner News

29d13c9

Update Misc/NEWS.d/next/Library/2020-02-11-13-01-38.bpo-38691.oND8Sk.rst

135259f

Co-Authored-By: Victor Stinner <vstinner@python.org>

Merge branch 'master' of https://github.com/python/cpython

794b948

[bpo-35885] Added indentation to configparser

37043f4

the-knights-who-say-ni added the CLA signed label Feb 16, 2020

bedevere-bot added the awaiting review label Feb 16, 2020

blurb-it bot and others added 7 commits February 16, 2020 17:38

📜🤖 Added by blurb_it.

1697dc5

[bpo-35885] Added indentation to configparser

8cc9279

Merge branch 'bpo-35885-configparserIndent' of https://github.com/ido…

e7092de

…mic/cpython into bpo-35885-configparserIndent

Merge branch 'master' of https://github.com/python/cpython

bfa3cd1

Merge branch 'master' of https://github.com/python/cpython

71b4de5

Removed residues

4be42f0

Merge branch 'master' into bpo-35885-configparserIndent

b45f883

idomic changed the title ~~Bpo-35885 configparser indent~~ bpo-35885: configparser indent Feb 16, 2020

idomic added 2 commits February 22, 2020 20:22

Fixing documentation

638eb47

Fixing documentation

9b57c26

taleinat requested changes Feb 23, 2020

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Feb 23, 2020

idomic closed this Feb 23, 2020

idomic deleted the bpo-35885-configparserIndent branch February 23, 2020 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-35885: configparser indent #18522

bpo-35885: configparser indent #18522

Uh oh!

idomic commented Feb 16, 2020 •

edited by bedevere-bot

Loading

Uh oh!

idomic commented Feb 23, 2020

Uh oh!

codecov bot commented Feb 23, 2020 •

edited

Loading

Uh oh!

taleinat Feb 23, 2020

Uh oh!

taleinat Feb 23, 2020

Uh oh!

taleinat Feb 23, 2020

Uh oh!

taleinat Feb 23, 2020

Uh oh!

bedevere-bot commented Feb 23, 2020

Uh oh!

taleinat commented Feb 23, 2020

Uh oh!

Uh oh!

		@@ -0,0 +1,3 @@
		:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.

	:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.
	Add a new parameter ``indent`` to :meth:`configparser.write()`.

		@@ -0,0 +1,3 @@
		:class:`configparser` :func:`write()` method have a new parameter `indent` of type string.
		When indent is set, the parser will indent the lines according to the given input value.

	Contributed by Ido Michael in :issue:`35885`
	Contributed by Ido Michael.

Uh oh!

bpo-35885: configparser indent #18522

bpo-35885: configparser indent #18522

Uh oh!

Conversation

idomic commented Feb 16, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idomic commented Feb 23, 2020

Uh oh!

codecov bot commented Feb 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

taleinat Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

taleinat Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

taleinat Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

taleinat Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 23, 2020

Uh oh!

taleinat commented Feb 23, 2020

Uh oh!

Uh oh!

idomic commented Feb 16, 2020 •

edited by bedevere-bot

Loading

codecov bot commented Feb 23, 2020 •

edited

Loading