bpo-39619 Fix os.chroot on HP-UX 11.31 #18495

inorton · 2020-02-12T22:36:03Z

Setting -D_XOPEN_SOURCE=700 on HP-UX causes system functions such as chroot to be undefined. This change stops _XOPEN_SOURCE being set on HP-UX

https://bugs.python.org/issue39619

the-knights-who-say-ni · 2020-02-12T22:36:06Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@inorton

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

inorton · 2020-02-12T22:42:06Z

On my HP system I now have a working os.chroot()

bash-4.3# ./python
Python 3.8.1 (default, Feb 12 2020, 22:51:01) [C] on hp-ux11
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.chroot("/")
>>>

codecov · 2020-02-12T23:09:20Z

Codecov Report

Merging #18495 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #18495     +/-   ##
=========================================
  Coverage   82.12%   82.12%             
=========================================
  Files        1956     1955      -1     
  Lines      589203   583854   -5349     
  Branches    44449    44449             
=========================================
- Hits       483863   479480   -4383     
+ Misses      95695    94731    -964     
+ Partials     9645     9643      -2

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 325 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e7d28...11b84c0. Read the comment docs.

benjaminp · 2020-02-13T04:55:10Z

This looks okay but please add a NEWS note and sign the CLA.

inorton · 2020-02-13T07:25:40Z

@benjaminp will do, I've already signed the CLA last night (hang on, just squashing my commits)


        Fix os.chroot on HP-UX 11.31

Setting `-D_XOPEN_SOURCE=700` on HP-UX causes system functions such as chroot to be undefined. This change stops `_XOPEN_SOURCE` begin set on HP-UX


        reST


        autoreconf

miss-islington · 2020-02-14T03:09:14Z

Thanks @inorton for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot · 2020-02-14T03:09:24Z

GH-18509 is a backport of this pull request to the 3.8 branch.


        closes bpo-39619 Fix os.chroot on HP-UX 11.31 (pythonGH-18495)