Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39663: IDLE: Add additional tests for pyparse #18536

Merged
merged 4 commits into from Feb 18, 2020
Merged

bpo-39663: IDLE: Add additional tests for pyparse #18536

merged 4 commits into from Feb 18, 2020
+17 −2

Conversation

@csabella
Copy link
Contributor

csabella commented Feb 17, 2020 •
edited by bedevere-bot

Add test cases when find_good_parse_start would return 0 instead of None.

https://bugs.python.org/issue39663
@csabella
bpo-39663: IDLE: Add additional tests for pyparse
Loading status checks…
ae7a74e
@csabella csabella requested a review from terryjreedy as a code owner Feb 17, 2020
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

csabella commented Feb 17, 2020

Test failure is unrelated to this change.
@python python deleted a comment from codecov bot Feb 18, 2020
@terryjreedy
terryjreedy reviewed Feb 18, 2020
View changes
Copy link
Member

terryjreedy left a comment

Looks good. I will factor out "is_char_in_string=lambda index: False" and add news items and when CI passes, merge and backport.
terryjreedy added 3 commits Feb 18, 2020
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_18536
759ff40
@terryjreedy
Add news item.
cc94acf
@terryjreedy
Factor out function.
Loading status checks…
17c170e
@terryjreedy terryjreedy merged commit ffda25f into python:master Feb 18, 2020
8 of 9 checks passed
8 of 9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200218.2 succeeded with issues
Details
bedevere/issue-number Issue number 39663 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 18, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 18, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 18, 2020
@csabella @miss-islington
bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)
acda9dc 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 18, 2020

GH-18541 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 18, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 18, 2020

GH-18542 is a backport of this pull request to the 3.8 branch.
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Feb 18, 2020

The unrelated macOS failure occurred again, but success seems to not currently be required.
miss-islington added a commit that referenced this pull request Feb 18, 2020
@miss-islington @csabella
bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fde0041 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Feb 18, 2020
@miss-islington @csabella
bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7fd752c 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
petdance added a commit to petdance/cpython that referenced this pull request Feb 19, 2020
@csabella @terryjreedy @petdance
bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)
d8558ee 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
petdance added a commit to petdance/cpython that referenced this pull request Feb 19, 2020
@csabella @terryjreedy @petdance
bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)
e855530 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees
No one assigned
Labels
CLA signed type-tests
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni
You can’t perform that action at this time.