Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39219: Fix SyntaxError attributes in the tokenizer. #17828

Merged
merged 1 commit into from Feb 12, 2020
Merged

bpo-39219: Fix SyntaxError attributes in the tokenizer. #17828

merged 1 commit into from Feb 12, 2020

Conversation

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 5, 2020 •
edited by bedevere-bot

  • Always set the text attribute.
  • Correct the offset attribute for non-ascii sources.

https://bugs.python.org/issue39219
@serhiy-storchaka serhiy-storchaka changed the title bpo-359331: Fix SyntaxError attributes in the tokenizer. bpo-39219: Fix SyntaxError attributes in the tokenizer. Jan 11, 2020
@serhiy-storchaka serhiy-storchaka force-pushed the serhiy-storchaka:tokenizer-syntax-error-text branch from aa5be8f to 309b924 Jan 11, 2020
@serhiy-storchaka
bpo-39219: Fix SyntaxError attributes in the tokenizer.
Loading status checks…
51d0cdc 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
@serhiy-storchaka serhiy-storchaka force-pushed the serhiy-storchaka:tokenizer-syntax-error-text branch from 309b924 to 51d0cdc Jan 11, 2020
@serhiy-storchaka serhiy-storchaka merged commit 0cc6b5e into python:master Feb 12, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200111.17 succeeded
Details
bedevere/issue-number Issue number 39219 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 12, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@serhiy-storchaka serhiy-storchaka deleted the serhiy-storchaka:tokenizer-syntax-error-text branch Feb 12, 2020
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @miss-islington
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
a0cbaa8 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
(cherry picked from commit 0cc6b5e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 12, 2020

GH-18479 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Feb 12, 2020
@miss-islington @serhiy-storchaka
bpo-39219: Fix SyntaxError attributes in the tokenizer. (GH-17828)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efd878c 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
(cherry picked from commit 0cc6b5e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
opavlyuk pushed a commit to opavlyuk/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka opavliuk
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
77c5fd5 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
4c1afba 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
02d4dfd 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
96b3c7a 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
e25edbc 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
08f33e0 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
26338b7 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
aadae70 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
c2bf1e0 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
199e69e 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
79b1383 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
7f81a66 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
affc627 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
014a527 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
8f3b319 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
99d4b36 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@serhiy-storchaka @petdance
bpo-39219: Fix SyntaxError attributes in the tokenizer. (pythonGH-17828)
251c969 
* Always set the text attribute.
* Correct the offset attribute for non-ascii sources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.